On 02-08-16 19:52, Kalle Valo wrote: > (Trimming CC) > > Baole Ni <baolex...@intel.com> writes: > >> I find that the developers often just specified the numeric value >> when calling a macro which is defined with a parameter for access permission. >> As we know, these numeric value for access permission have had the >> corresponding macro, >> and that using macro can improve the robustness and readability of the code, >> thus, I suggest replacing the numeric parameter with the macro. >> >> Signed-off-by: Chuansheng Liu <chuansheng....@intel.com> >> Signed-off-by: Baole Ni <baolex...@intel.com> >> --- >> drivers/net/wireless/ath/wcn36xx/main.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Over 1000 patches? It's totally inapproriate to spam people's inboxes > (including mine) like this. PLEASE first study how kernel development > works and then start with something small, not like this. > > I'm dropping all patches from this patchset.
And this type of change has been tried before and burned by Linus as everybody with a bit of *nix background knows the meaning of the numerical access permissions. Regards, Arend -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
