RE: [PATCH] cfg80211: Add support for user configurable beacon data rate

[Undekari, Sunil Dutt]

> Doesn't this have to check that it actually got information for the right 
> band?
Hi Johannes ,
nl80211_parse_tx_bitrate_mask ( a new wrapper to the existing functionality in 
nl80211_set_tx_bitrate_mask ) does this , isn't ? 

Regards,
Sunil



-----Original Message-----
From: Johannes Berg [mailto:johan...@sipsolutions.net] 
Sent: Friday, August 5, 2016 2:33 PM
To: Kushwaha, Purushottam <pkush...@qti.qualcomm.com>
Cc: linux-wireless@vger.kernel.org; Malinen, Jouni <jo...@qca.qualcomm.com>; 
Undekari, Sunil Dutt <usd...@qti.qualcomm.com>; Kondabattini, Ganesh 
<gane...@qti.qualcomm.com>; Kalikot Veetil, Mahesh Kumar 
<mkali...@qca.qualcomm.com>; Hullur Subramanyam, Amarnath 
<amarn...@qca.qualcomm.com>
Subject: Re: [PATCH] cfg80211: Add support for user configurable beacon data 
rate

On Fri, 2016-08-05 at 10:05 +0530, Purushottam Kushwaha wrote:
> 
> +static int nl80211_parse_tx_bitrate_mask(struct genl_info *info,
> +                                      struct cfg80211_bitrate_mask *mask);

I think you should move the function instead.

> @@ -3457,6 +3459,11 @@ static int nl80211_start_ap(struct sk_buff 
> *skb, struct genl_info *info)
>       err = cfg80211_validate_beacon_int(rdev,
> params.beacon_interval);
>       if (err)
>               return err;
> +     if (info->attrs[NL80211_ATTR_TX_RATES]) {
> +             err = nl80211_parse_tx_bitrate_mask(info,
> &params.beacon_rate);
> +             if (err)
> +                     return err;
> +     }

Doesn't this have to check that it actually got information for the right band?

johannes
N�����r��y����b�X��ǧv�^�)޺{.n�+����{��*ޕ�,�{ay�ʇڙ�,j��f���h���z��w���
���j:+v���w�j�m��������zZ+�����ݢj"��!�i