On 22-11-2016 14:38, Johannes Berg wrote: > >> + if (wiphy->min_sched_scan_plan_interval && >> + request->scan_plans[i].interval < >> + wiphy->min_sched_scan_plan_interval) >> + return -EINVAL; >> > I'm not sure we should break the API that way - just move it up if it's > smaller?
Are we? Currently, the minimum is not checked in nl80211, but that does not say anything about the driver which might validate the interval as well and return an error. What made me start looking at this is that in brcmfmac the interval in the request was ignored and a fixed interval was provisioned in the device. I wanted to fix that but was not sure if I needed to check it against our firmware min..max range and what the appropriate error handling should be. If silently changing what user-space is requesting is fine for this, I am happy to make it so. Preferably in nl80211. Regards, Arend
