On 13-12-2016 17:15, Johannes Berg wrote: > >> + case 14: >> + if (!rdev->wiphy.gscan) { >> + /* done */ >> + state->split_start = 0; >> + break; >> + } >> > > Nit, but I'm not really happy with this - this assumes that case 14 is > the last case, if anyone ever adds one we break this code but it would > still work if the device has gscan. Move the gscan stuff into a new > function and make that return immediately if gscan is NULL or so?
Agree. When coding this piece I was aware that this would need to change when 'case 15' would be added, which is probably too easy to overlook. I will change it. Regards, Arend