On 18-1-2017 10:06, Rafał Miłecki wrote: > On 18 January 2017 at 09:58, Arend Van Spriel > <arend.vanspr...@broadcom.com> wrote: >> On 17-1-2017 17:34, Rafał Miłecki wrote: >>> From: Rafał Miłecki <ra...@milecki.pl> >>> >>> Function brcmf_c_set_joinpref_default is in common.c, so move it to the >>> related header. All other (touched) ones are in core.c so take them out >>> of the bus.h. >>> I just needed to include bus.h to have enum brcmf_bus_state defined. >> >> I prefer to keep the bus api in separate include file so please leave >> those. That leaves the move of brcmf_c_set_joinpref_default(). Please >> send a v2 and consider it acked by me. > > Oh, I just realized there isn't bus.c! Would that make sense to move > these functions from core.c to new bus.c then?
I have no strong opinion about it. Right now it seems a bit overzealous, but I have been considering adding counters/statistics on bus layer so the amount of code may justify a separate source file. Regards, Arend
