Iain Hunter <drhunte...@gmail.com> writes:

> Enable AP support for allmulticast for MDNS. It can be enabled by bringing
> up the interface with ip command with argument allmulticast on
>
> Signed-off-by:Iain Hunter <i-hunt...@ti.com>

There should be a space after ':' and before your name.

> --- a/drivers/net/wireless/ti/wlcore/main.c
> +++ b/drivers/net/wireless/ti/wlcore/main.c
> @@ -3281,6 +3281,21 @@ static void wl1271_op_configure_filter(struct 
> ieee80211_hw *hw,
>                       if (ret < 0)
>                               goto out_sleep;
>               }
> +
> +        /*
> +         * If interface in AP mode and created with allmulticast then disable
> +         * the firmware filters so that all multicast packets are passed
> +         * This is mandatory for MDNS based discovery protocols 
> +         */
> +             if (wlvif->bss_type == BSS_TYPE_AP_BSS) {

The comment looks wrongly indented.

> +                     if (*total & FIF_ALLMULTI) {
> +                             ret = wl1271_acx_group_address_tbl(wl, wlvif,
> +                                                     false,
> +                                                     NULL, 0);
> +                             if (ret < 0)
> +                                     goto out_sleep;
> +                             }

Also the closing bracket here is not indented correctly.

-- 
Kalle Valo

Reply via email to