Re: [PATCH] dt-bindings: add device tree binding for Allwinner XR819 SDIO Wi-Fi

[Rob Herring]

On Tue, Jul 18, 2017 at 03:29:40PM +0800, Icenowy Zheng wrote:
> Allwinner XR819 is a SDIO Wi-Fi chip, which has the functionality to use
> an out-of-band interrupt pin instead of SDIO in-band interrupt.
> 
> Add the device tree binding of this chip, in order to make it possible
> to add this interrupt pin to device trees.
> 
> Signed-off-by: Icenowy Zheng <icen...@aosc.io>
> ---
>  .../bindings/net/wireless/allwinner,xr819.txt      | 37 
> ++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/net/wireless/allwinner,xr819.txt
> 
> diff --git 
> a/Documentation/devicetree/bindings/net/wireless/allwinner,xr819.txt 
> b/Documentation/devicetree/bindings/net/wireless/allwinner,xr819.txt
> new file mode 100644
> index 000000000000..64dd9c1c0584
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/wireless/allwinner,xr819.txt
> @@ -0,0 +1,37 @@
> +Allwinner XRadio wireless SDIO devices
> +
> +This node provides properties for controlling the XRadio wireless device. The
> +node is expected to be specified as a child node to the SDIO controller that
> +connects the device to the system.
> +
> +Required properties:
> +
> + - compatible : Should be "allwinner,xr819".

reg is also required.

> +
> +Optional properties:
> + - interrupt-parent : the phandle for the interrupt controller to which the
> +     device interrupts are connected.
> + - interrupts : specifies attributes for the out-of-band interrupt 
> (host-wake).
> +     When not specified the device will use in-band SDIO interrupts.
> +
> +Example:
> +
> +mmc1: mmc@01c10000 {
> +     #address-cells = <1>;
> +     #size-cells = <0>;
> +
> +     pinctrl-names = "default";
> +     pinctrl-0 = <&mmc1_pins_a>;
> +     vmmc-supply = <&reg_vcc_wifi>;
> +     mmc-pwrseq = <&wifi_pwrseq>;
> +     bus-width = <4>;
> +     non-removable;
> +     status = "okay";

Don't show status in examples.

> +
> +     xr819: sdio_wifi@1 {

wifi@1

> +             reg = <1>;
> +             compatible = "allwinner,xr819";
> +             interrupt-parent = <&pio>;
> +             interrupts = <6 10 IRQ_TYPE_EDGE_RISING>;
> +     };
> +};
> -- 
> 2.13.0
>