Arend van Spriel <arend.vanspr...@broadcom.com> writes:
>>>> @@ -1157,18 +1159,81 @@ static int rsi_mac80211_sta_add(struct
>>>> ieee80211_hw *hw,
>>>> {
>>>> struct rsi_hw *adapter = hw->priv;
>>>> struct rsi_common *common = adapter->priv;
>>>> + bool sta_exist = false;
>>>> + struct rsi_sta *rsta;
>>>> +
>>>> + print_hex_dump(KERN_INFO, "Station add: ", DUMP_PREFIX_OFFSET,
>>>> + 16, 1, sta->addr, ETH_ALEN, 0);
>>>
>>> The driver should not spam the logs every time a client connects, so
>>> this should be a debug message.
>
> I am wondering why print_hex_dump() is used for printing the station
> mac address. Just use: pr_debug("Station add: %pM\n", sta->addr);
Good point. Except that IIRC rsi has it's own debugging macros and you
can use those, you don't need to use pr_debug() (unless you want to).
--
Kalle Valo
