Arend van Spriel <arend.vanspr...@broadcom.com> writes: > In the function brcmf_sdio_firmware_callback() the driver is > unbound from the sdio function devices in the error path. > However, the order in which it is done resulted in a use-after-free > issue (see brcmf_ops_sdio_remove() in bcmsdh.c). Hence change > the order and first unbind sdio function #2 device and then > unbind sdio function #1 device. > > Cc: sta...@vger.kernel.org # v4.12.x > Fixes: 7a51461fc2da ("brcmfmac: unbind all devices upon failure in firmware > callback") > Reported-by: Stefan Wahren <stefan.wah...@i2se.com> > Reviewed-by: Hante Meuleman <hante.meule...@broadcom.com> > Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> > Reviewed-by: Franky Lin <franky....@broadcom.com> > Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com>
I'll queue this for v4.15. -- Kalle Valo