Sergey Matyukevich <sergey.matyukevich...@quantenna.com> writes: > Center frequency is not enough to describe the channel in HT and VHT > modes. For 40MHz and 80MHz channels both primary channel and center > frequency should be specified in order to qualify channel completely. > This change adds primary channel info into qlink_chandef structure. > > Signed-off-by: Sergey Matyukevich <sergey.matyukevich...@quantenna.com>
[...] > +/** > * struct qlink_chandef - qlink channel definition > * > + * @chan: primary channel definition > * @center_freq1: center frequency of first segment > * @center_freq2: center frequency of second segment (80+80 only) > * @width: channel width, one of @enum qlink_channel_width > */ > struct qlink_chandef { > + struct qlink_channel chan; > __le16 center_freq1; > __le16 center_freq2; > u8 width; > - u8 rsvd[3]; > + u8 rsvd; > } __packed; Doesn't this break backwards compatibility with the older firmware? The basic princinple is that old firmware images continue to work with newer driver (or there will be a firmware image with new name, eg. fw-2.bin). You can check how iwlwifi does that. As this is a new driver I guess it doesn't matter that much to break it, but please keep this in mind in the future. -- Kalle Valo