On Wed, 2018-03-21 at 10:27 -0500, Denis Kenzior wrote: > > cfg80211_leave also messes with scans and autodisconnect_wk didn't. So > I played it safe as I didn't want to introduce any silent semantic changes.
Makes sense, but we could pass an argument and avoid duplicating the code? > Also, cfg80211_leave uses stop_ap/leave_ibss with notify argument being > true, while I thought it made more sense to use false (as there's > arguably nobody left to pay attention to it) and to be consistent with > nl80211_stop_ap and nl80211_leave_ibss which also use false. Fair enough. > I don't see an issue with using cfg80211_leave though. Just tell me > which way you prefer. It just seemed duplicated, ultimately I don't think I care all that much. johannes
