On 4/18/2018 3:16 PM, Kalle Valo wrote:
(fixing top posting)

govi...@codeaurora.org writes:

On 2018-04-18 12:36, Sebastian Gottschall wrote:
from my point of view powersave should be optional and not forced.

consider :
iw dev <devname> set power_save on/off

so there is already a config option made for that purpose,

Thanks Sebastian for your review. Agree this should not be forced with
in driver.

I will check if i can set the idle ps at the end of
ath10k_mac_vif_setup_ps by checking arvif->ps.
I will update the patch accordingly.

So what power save is this exactly? I assumed it's some bus level power
save (turning of clocks etc) but is it actually 802.11 power save?

I also suspected bus level power save and I would say runtime-pm framework should be considered for that.

Regards,
Arend


Reply via email to