On Wed, 2018-04-18 at 15:35 +0530, Amit Pundir wrote:

>               if (skb->data[transaction->aid_len + 2] !=
> -                 NFC_EVT_TRANSACTION_PARAMS_TAG)
> +                 NFC_EVT_TRANSACTION_PARAMS_TAG ||
> +                 skb->len < transaction->aid_len + transaction-
> >params_len + 4) {

> +                     devm_kfree(dev, transaction);

Oh, no.

This is not memory leak per se, this is bad choice of devm_ API where it
should use plain kmalloc() / kfree().

>                       return -EPROTO;
> +             }

-- 
Andy Shevchenko <andriy.shevche...@linux.intel.com>
Intel Finland Oy

Reply via email to