Tamizh chelvam <tami...@codeaurora.org> writes: > On 2018-03-26 21:19, Kalle Valo wrote: >> Tamizh chelvam <tami...@codeaurora.org> writes: >> >>> @@ -4455,6 +4461,8 @@ void ath10k_wmi_event_pdev_tpc_config(struct >>> ath10k *ar, struct sk_buff *skb) >>> __le32_to_cpu(ev->twice_max_rd_power) / 2, >>> __le32_to_cpu(ev->num_tx_chain), >>> __le32_to_cpu(ev->rate_max)); >>> +exit: >>> + complete(&ar->debug.tpc_complete); >>> } >> >> And why do you need this anyway? The commit log doesn't explain that. > > Previously this complete call was not there in the error case and > without this we will get "failed to request tpc config stats: -110" > along with the error message and this is a timeout warning. I've added > this since we have received the event and the warning message is > incorrect. I'll remove this complete call here since it is a harmless > message and send the next version of a patch.
Yeah, that's a good idea. If you want to add the complete it's better to do that in it's own patch (and with a proper explanation in the commit log). -- Kalle Valo
