On Mon, Jul 9, 2018 at 10:09 PM, Boris Brezillon <boris.brezil...@bootlin.com> wrote: > Fixes the following smatch warning: > > drivers/mtd/nand/raw/sunxi_nand.c:551 sunxi_nfc_read_byte() error: > uninitialized symbol 'ret'. > > Signed-off-by: Boris Brezillon <boris.brezil...@bootlin.com> > --- > drivers/mtd/nand/raw/sunxi_nand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/sunxi_nand.c > b/drivers/mtd/nand/raw/sunxi_nand.c > index 99043c3a4fa7..4b11cd4a79be 100644 > --- a/drivers/mtd/nand/raw/sunxi_nand.c > +++ b/drivers/mtd/nand/raw/sunxi_nand.c > @@ -544,7 +544,7 @@ static void sunxi_nfc_write_buf(struct mtd_info *mtd, > const uint8_t *buf, > > static uint8_t sunxi_nfc_read_byte(struct mtd_info *mtd) > { > - uint8_t ret; > + uint8_t ret = 0; > > sunxi_nfc_read_buf(mtd, &ret, 1); >
Should there perhaps be a warning when no data was returned after a timeout? Arnd