> -----Original Message-----
> From: Stanislaw Gruszka [mailto:sgrus...@redhat.com]
> Sent: Thursday, October 04, 2018 10:23 PM
> To: Tony Chuang
> Cc: kv...@codeaurora.org; larry.fin...@lwfinger.net; Pkshih; Andy Huang;
> linux-wireless@vger.kernel.org
> Subject: Re: [RFC v3 08/12] rtw88: debug files
>
> On Wed, Oct 03, 2018 at 07:20:55PM +0800, yhchu...@realtek.com wrote:
> > +static int rtw_debugfs_get_rsvd_page(struct seq_file *m, void *v)
> > +{
> > + struct rtw_debugfs_priv *debugfs_priv = m->private;
> > + struct rtw_dev *rtwdev = debugfs_priv->rtwdev;
> > + u8 page_size = rtwdev->chip->page_size;
> > + u32 buf_size = debugfs_priv->rsvd_page.page_num * page_size;
> > + u32 offset = debugfs_priv->rsvd_page.page_offset * page_size;
> > + u8 *buf = vzalloc(buf_size);
> Error check.
>
OK
> > +void rtw_debugfs_init(struct rtw_dev *rtwdev)
> > +{
> > + debugfs_topdir = debugfs_create_dir("rtw88", NULL);
>
> You should use rtwdev->hw->wiphy->debugfsdir like other drivers.
>
OK
> Thanks
> Stanislaw
>
Yan-Hsuan CHuang
