Sergey Matyukevich <sergey.matyukevich...@quantenna.com> writes:

> This patch adds support for QSR1000/QSR2000 family of chipsets
> to qtnfmac_pcie platform driver.
>
> QSR1000/QSR2000 (aka Topaz) is a family of 80MHz, 11ac Wave2,
> 4x4/2x4/2x2 chips, including single and dual band devices.
> Depending on specific chip model and firmware in use, either
> STA or both STA and AP modes are supported.
>
> Patch adds Topaz support to qtnfmac_pcie driver. It is possible
> to enable both Topaz and Pearl support in kernel configuration.
> In that case proper platform bus will be selected on probing
> based on chip ID.
>
> Signed-off-by: Igor Mitsyanko <igor.mitsyanko...@quantenna.com>
> Signed-off-by: Sergey Matyukevich <sergey.matyukevich...@quantenna.com>
> Signed-off-by: Andrey Shevchenko <ashevche...@quantenna.com>

[...]

> +config QTNFMAC_TOPAZ_PCIE
> +     tristate "Quantenna QSR1000/QSR2000 PCIe support"
> +     default n
> +     depends on PCI && CFG80211
> +     select QTNFMAC
> +     select FW_LOADER
> +     select CRC32
> +     help
> +       This option adds support for wireless adapters based on Quantenna
> +       802.11ac QSR1000/QSR2000 (aka Topaz) FullMAC chipset
> +       running over PCIe.
> +
> +       If you choose to build it as a module, two modules will be built:
> +       qtnfmac.ko and qtnfmac_pcie.ko.

I'm not really fond of adding a Kconfig option for every supported
hardware version unless there are very good reasons (memory savings
etc). So is this really needed?

A much better approach would be to have a generic QTNFMAC_PCIE option
which can be used to include or exclude all PCI code.

-- 
Kalle Valo

Reply via email to