On 11/8/2018 4:48 AM, Chi-Hsien Lin wrote:
From: Wright Feng <wright.f...@cypress.com>

APSTA can work on two band concurrently with using VSDB(Virtual
Simultaneous Dual-Band) or RSDB(Real Simultaneous Dual-Band) features.
In this case, we have to keep apsta is 1 in firmware side. However, if
we start wpa_supplicant on wlan0 and then start hostapd on wlan 1, the
apsta will be set to 0, and we will see data stall on wlan0(station)
So that, we only set apsta to 1 when AP start on primary interface.

The description makes my head spin. From reading the commit message I think the code should add a !VSDB check instead of dropping the !RSDB check. Would you agree?

Regards,
Arend

Signed-off-by: Wright Feng <wright.f...@cypress.com>
Signed-off-by: Chi-Hsien Lin <chi-hsien....@cypress.com>
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Reply via email to