Re: [PATCH] mt76: handle protocol error to proper deinit rx_tasklet

[Lorenzo Bianconi]

> During removal of usb dongle, noticed many unhandled rx urb
> below. This this patch, make it possible and early completion
> of the rx tasklet.
>
> mt76x2u 1-3.4.3.1.2:1.0: rx urb failed: -71
> mt76x2u 1-3.4.3.1.2:1.0: rx urb failed: -71
> mt76x2u 1-3.4.3.1.2:1.0: rx urb failed: -71
> mt76x2u 1-3.4.3.1.2:1.0: rx urb failed: -71
> ...

Hi Eduardo,

I think EPROTO is a more general error (it is not strictly related to
device removal)
and it could happen even during normal operation. In this case I guess we should
reinsert the urb to usb-core.

Regards,
Lorenzo

>
> Signed-off-by: Eduardo Abinader <eduardoabina...@gmail.com>
> ---
>  drivers/net/wireless/mediatek/mt76/usb.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/usb.c 
> b/drivers/net/wireless/mediatek/mt76/usb.c
> index 5f0faf07c346..dc33df9cd155 100644
> --- a/drivers/net/wireless/mediatek/mt76/usb.c
> +++ b/drivers/net/wireless/mediatek/mt76/usb.c
> @@ -446,6 +446,7 @@ static void mt76u_complete_rx(struct urb *urb)
>         case -ECONNRESET:
>         case -ESHUTDOWN:
>         case -ENOENT:
> +       case -EPROTO:
>                 return;
>         default:
>                 dev_err(dev->dev, "rx urb failed: %d\n", urb->status);
> --
> 2.19.1
>