Arend Van Spriel <arend.vanspr...@broadcom.com> writes:
> On 3/21/2019 8:35 AM, Kalle Valo wrote:
>> Sergey Matyukevich <sergey.matyukevich...@quantenna.com> writes:
>>
>>>>> Fix creation of debugfs entries for qtnfmac wireless card: use separate
>>>>> directories for different wireless cards. This commit enables support
>>>>> for multiple qtnfmac wireless cards on the same PCIe host.
>>>>>
>>>>> Signed-off-by: Sergey Matyukevich <sergey.matyukevich...@quantenna.com>
>>>>> ---
>>>>> drivers/net/wireless/quantenna/qtnfmac/pcie/pcie.c | 6 +++++-
>>>>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/drivers/net/wireless/quantenna/qtnfmac/pcie/pcie.c
>>>>> b/drivers/net/wireless/quantenna/qtnfmac/pcie/pcie.c
>>>>> index b561b75e4433..56fc6d49c121 100644
>>>>> --- a/drivers/net/wireless/quantenna/qtnfmac/pcie/pcie.c
>>>>> +++ b/drivers/net/wireless/quantenna/qtnfmac/pcie/pcie.c
>>>>> @@ -130,6 +130,8 @@ static int qtnf_dbg_shm_stats(struct seq_file *s,
>>>>> void *data)
>>>>>
>>>>> int qtnf_pcie_fw_boot_done(struct qtnf_bus *bus)
>>>>> {
>>>>> + struct qtnf_pcie_bus_priv *priv = get_bus_priv(bus);
>>>>> + char card_id[64];
>>>>> int ret;
>>>>>
>>>>> bus->fw_state = QTNF_FW_STATE_BOOT_DONE;
>>>>> @@ -137,7 +139,9 @@ int qtnf_pcie_fw_boot_done(struct qtnf_bus *bus)
>>>>> if (ret) {
>>>>> pr_err("failed to attach core\n");
>>>>> } else {
>>>>> - qtnf_debugfs_init(bus, DRV_NAME);
>>>>> + snprintf(card_id, sizeof(card_id), "%s:%s",
>>>>> + DRV_NAME, pci_name(priv->pdev));
>>>>
>>>> Can you give an example for the path?
>>>>
>>>
>>> For instance: /sys/kernel/debug/qtnfmac_pcie:0000:01:00.0
>>
>> TBH not really fond of that. What about
>> "/sys/kernel/debug/qtnfmac/pcie:0000:01:00.0"? IIRC iwlwifi used
>> something like that.
>
> In brcmfmac we used to have it like that, but I changed it to use
> wiphy debugfs, ie. /sys/kernel/debug/ieee80211/phyX/.
Yeah, that's much better.
--
Kalle Valo
