On Mon, 2019-03-25 at 15:44 +0000, Sergey Matyukevich wrote: > > > > > I worry slightly about locking too, since there's no protection on the > > wdev->current_bss pointer here. > > Ok, I will add WARN_ON. As for locking, this function is supposed to be > called with wdev->mtx held, see ASSERT_WDEV_LOCK. Do you think this may > not be enough ?
Oops, no, that's definitely sufficient. I missed it. > I need to check mwifiex more carefully, but other cfg80211_ch_switch_notify > users (mac80211, ath6kl, qtnfmac) seem to do that locking properly. Well I guess they'd assert and then do something unsafe, so wouldn't worry about it. johannes
