> Lorenzo Bianconi <[email protected]> writes:
> 
> > Introduce a knob in mt7603 debugfs in order to enable/disable
> > edcca processing
> >
> > Signed-off-by: Lorenzo Bianconi <[email protected]>
> 
> It's good to explain what edcca does and how the file is used supposed
> to be used. In other words, have a small introduction for the user.

Hi Kalle,

edcca is used for adjusting energy detect based on CCA thresholds.
The code was already there so I just reported the acronym.

> 
> > @@ -48,6 +77,7 @@ void mt7603_init_debugfs(struct mt7603_dev *dev)
> >     if (!dir)
> >             return;
> >  
> > +   debugfs_create_file("edcca", 0400, dir, dev, &fops_edcca);
> 
> Why 0400 and not 0600?

yes, right. There is the same issue in mt76x02 code, I will fix both of them.
Thx.

Regards,
Lorenzo

> 
> -- 
> Kalle Valo

Attachment: signature.asc
Description: PGP signature

Reply via email to