Hi Kalle, Thomas,
I added SPDX tags in brcm80211 driver sources. Although it is a
no-brainer I decided to run checkpatch for the changes and quirky stuff
started to happen. For all files I added:
// SPDX-License-Identifier
but checkpatch started complaining I should use /* ... */ instead of //.
WARNING: Improper SPDX comment style for
'drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h', please
use '/*' instead
#29: FILE: drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h:1:
+// SPDX-License-Identifier: ISC
So I edited all patches and ran again. And again it started complaining.
WARNING: Improper SPDX comment style for
'drivers/net/wireless/broadcom/brcm80211/brcmsmac/aiutils.c', please use
'//' instead
So now I am in a bonkers state. It seems for header files we want /* */
and for c files we want //. For real?
This is on wireless-drivers-next so maybe it is already fixed, but I
think this should be fixed.
Regards,
Arend
