Hi, On Tue, Jun 18, 2019 at 8:35 AM Ulf Hansson <[email protected]> wrote: > > It looks like the original idea behind always doing a re-initialization of > a removable SDIO card during system resume in mmc_sdio_resume(), is to try > to play safe to detect whether the card has been removed. > > However, this seems like a really a bad idea as it will most likely screw > things up, especially when the card is expected to remain powered on during > system suspend by the SDIO func driver. > > Let's fix this, simply by trusting that the detect work checks if the card > is alive and inserted, which is being scheduled at the PM_POST_SUSPEND > notification anyway. > > Signed-off-by: Ulf Hansson <[email protected]> > --- > drivers/mmc/core/sdio.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-)
I'm not sure if it's even worth mentioning since the device I tested was rk3288-veyron (both WiFi variants) and we have a non-removable, powered-in-suspend, wakeup-disabled card. That means it isn't affected at all by your change. ...but I suppose I can at least confirm that your change didn't break me if that's worth anything. :-P Tested-by: Douglas Anderson <[email protected]> I would also say that, though I don't have any history here, your patch seems reasonable to me. So you can add a: Reviewed-by: Douglas Anderson <[email protected]>
