In message: [linux-yocto][yocto-kernel-cache master/yocto-5.2][PATCH] features: avoid enabling edac feature in mips on 27/11/2019 yanfei...@windriver.com wrote:
> From: Yanfei Xu <yanfei...@windriver.com> > > When some layer include this edac feature and bitbake kernel ARCH > =mips, that will cause some warning masseges. > > CONFIG_EDAC and CONFIG_EDAC_DEBUG depend on CONFIG_EDAC_SUPPORT, > but CONFIG_EDAC_SUPPORT isn't enabled in most of mips bsps(except > CAVIUM_OCTEON_SOC, however CAVIUM_OCTEON_SOC is not defined in > bsps) > > Signed-off-by: Yanfei Xu <yanfei...@windriver.com> > --- > features/edac/edac-enable.scc | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/features/edac/edac-enable.scc b/features/edac/edac-enable.scc > index c60d2790..f9a56af0 100644 > --- a/features/edac/edac-enable.scc > +++ b/features/edac/edac-enable.scc > @@ -1,5 +1,7 @@ > # SPDX-License-Identifier: MIT > -define KFEATURE_DESCRIPTION "Enable core EDAC functionality" > -define KFEATURE_COMPATIBILITY board > +if [ "$KARCH" != "mips" ]; then > + define KFEATURE_DESCRIPTION "Enable core EDAC functionality" > + define KFEATURE_COMPATIBILITY board We should leave the feature descriptions outside of the if statement. That being said, this fragment isn't included directly by any of the common features/kernel types or other fragments. We already have the compatibility tagged as "board", so really, only boards with the right hardware should be including this fragment. Which leads me to this question: how is this feature being included by those mips boards ? Is it via KERNEL_FEATURES or some other mechanism ? The reason I ask, is that we should probably do an architecture level exclude on those boards/layers versus adding an if statement to the feature fragment (or best case, it should be done in both places). Bruce > > -kconf hardware edac.cfg > + kconf hardware edac.cfg > +fi > -- > 2.23.0 >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#8125): https://lists.yoctoproject.org/g/linux-yocto/message/8125 Mute This Topic: https://lists.yoctoproject.org/mt/63635414/21656 Group Owner: linux-yocto+ow...@lists.yoctoproject.org Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
