> -----Original Message----- > From: Darren Hart [mailto:dvh...@linux.intel.com] > Sent: Wednesday, March 05, 2014 5:10 AM > To: Ong, Boon Leong; linux-yocto@yoctoproject.org > Subject: Re: [linux-yocto] [PATCH 1/1] meta: update mohonpeak.cfg for SATA, > SMBus, LPC, WDT, crypto & highmem64g > > On 3/4/14, 15:20, "boon.leong....@intel.com" <boon.leong....@intel.com> > wrote: > > >From: Ong Boon Leong <boon.leong....@intel.com> > > With Linux-yocto, it's good practice to include the version in the subject: > > [PATCH 1/1][3.4] meta: ... I understand that on the cover-letter, we practice that to channel the commits correctly. Adding [3.4] tag in the subject of patch-set is also encouraged? If yes, we need to add this manually after create-pull-request script since we don't want to have commit title that have [3.4] tag. Is my understanding correct? > > > > > > >Update mohonpeak.cfg to enable SMBus & iSMT driver, crypto framework, > >LPC, watchdog-timer & >4G memory for 32-bit build. The update is > >possible due to recent merge of LTS/LTSI commits available since 3.4.74. > > > >Signed-off-by: Ong Boon Leong <boon.leong....@intel.com> > >--- > > meta/cfg/kernel-cache/bsp/mohonpeak/mohonpeak.cfg | 23 > >++++++++++++++++++--- > > 1 file changed, 20 insertions(+), 3 deletions(-) > > > >diff --git a/meta/cfg/kernel-cache/bsp/mohonpeak/mohonpeak.cfg > >b/meta/cfg/kernel-cache/bsp/mohonpeak/mohonpeak.cfg > >index 2111aed..d0d1d92 100644 > >--- a/meta/cfg/kernel-cache/bsp/mohonpeak/mohonpeak.cfg > >+++ b/meta/cfg/kernel-cache/bsp/mohonpeak/mohonpeak.cfg > >@@ -1,13 +1,30 @@ > >-# Basic hardware support for the box - network, PCI, sound > >+# Basic hardware support for the box > > CONFIG_ATA=y > > CONFIG_ATA_GENERIC=y > > CONFIG_ATA_SFF=y > >+CONFIG_SATA_AHCI=y > > CONFIG_PCI=y > >-CONFIG_PATA_SCH=y > > > Were the SATA and PATA changes intentional? They aren't mentioned in the > commit message and don't seem likely to have been impacted by the general > update. If so, please not it in the message. General updates are OK if they > are > documented as such, but this one is described fairly specifically, so this > appears > inadvertent. > > > CONFIG_PCIEPORTBUS=y > > CONFIG_CHR_DEV_SG=y > >-CONFIG_I2C=y > > CONFIG_PM=y > > CONFIG_BACKLIGHT_LCD_SUPPORT=y > > CONFIG_BACKLIGHT_CLASS_DEVICE=y > > CONFIG_INPUT=y > >+# Enable >4G memory on 32-bit system > >+CONFIG_HIGHMEM64G=y > >+CONFIG_X86_PAE=y > >+# Linux Crypto Framework > >+CONFIG_CRYPTO_CTR=y > >+CONFIG_CRYPTO_CCM=m > >+CONFIG_CRYPTO_GCM=m > >+CONFIG_CRYPTO_XCBC=m > >+CONFIG_CRYPTO_VMAC=m > >+CONFIG_CRYPTO_CTS=m > >+# SMBus & ISMT Driver for Mohon-peak > >+CONFIG_I2C=y > >+CONFIG_I2C_I801=m > >+CONFIG_I2C_ISMT=m > >+CONFIG_I2C_CHARDEV=y > >+# LPC driver & Watchdog Timer > >+CONFIG_LPC_ICH=m > >+CONFIG_ITCO_WDT=y > >-- > >1.7.10.4 > > > > Otherwise looks good. > > -- > Darren Hart > Yocto Project - Linux Kernel > Intel Open Source Technology Center > > >
_______________________________________________ linux-yocto mailing list linux-yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/linux-yocto
