Bruce, We are going to remove patch 03/18 and submit the rest.
I will follow up with a pull request. Also when will you be shutting down 3.4? Do you have a last day to submit? Charlie -----Original Message----- From: Bruce Ashfield [mailto:bruce.ashfi...@windriver.com] Sent: Thursday, February 27, 2014 7:23 PM To: Paul, Charlie; Darren Hart (dvh...@linux.intel.com) Cc: linux-yocto@yoctoproject.org Subject: Re: FW: [PATCH 03/18] arch/powerpc: Checking in correct USB entries to ACP3421 DTS On 2/27/2014, 5:56 PM, Paul, Charlie wrote: > Please see engineer comments below Sorry for being a pain on this, it is a good learning experience for everyone. It was obvious from the patch that it wasn't just the uart, but more devices on the board. What the description of the sync still doesn't tell us .. is what happens if this isn't done. If the uboot device tree is used, and not the Linux one .. why sync it ? And why have it at all? Bruce > > -----Original Message----- > From: Rao, Sangeetha (Sangeetha) [mailto:sangeetha....@lsi.com] > Sent: Thursday, February 27, 2014 1:32 PM > To: Paul, Charlie > Cc: Rao, Sangeetha (Sangeetha) > Subject: RE: [PATCH 03/18] arch/powerpc: Checking in correct USB > entries to ACP3421 DTS > > Charlie, > > The DTS changes are not just for UART as you may have noted. It is just that > I updated it based on what we had in U-boot so that we are in sync with > U-boot. Please note that even though we boot using multi.fit on PPC eval > boards, the DTS from U-boot is the one that is getting used and not the one > that is in Linux.fit. > > Thanks, > Sangeetha > > -----Original Message----- > From: Paul, Charlie [mailto:charlie.p...@windriver.com] > Sent: Thursday, February 27, 2014 1:07 PM > To: Rao, Sangeetha (Sangeetha) > Subject: FW: [PATCH 03/18] arch/powerpc: Checking in correct USB > entries to ACP3421 DTS > > > > -----Original Message----- > From: Bruce Ashfield [mailto:bruce.ashfi...@windriver.com] > Sent: Thursday, February 27, 2014 12:00 PM > To: Charlie Paul; linux-yocto@yoctoproject.org > Cc: Paul, Charlie; SangeethaRao > Subject: Re: [PATCH 03/18] arch/powerpc: Checking in correct USB > entries to ACP3421 DTS > > On 14-02-27 02:25 PM, Charlie Paul wrote: >> From: SangeethaRao <sangeetha....@lsi.com> >> >> The latest USB driver in 3.10 Yocto expects more information from DTS >> than what existed in ACP3421 DTS. The ACP3421 DTS was updated with >> the extra information based on LSI hardware configurations. > > And without the extra information .. what do we see on boot ? I'm assuming > silent boot death , since you are messing with the uart. > > If that is the case, get that into the change log, and send the pull request. > > If it isn't the case, I await the explanation :) > > Bruce > >> >> Signed-off-by: SangeethaRao <sangeetha....@lsi.com> >> --- >> arch/powerpc/boot/dts/acp342x.dts | 33 +++++++++++++++++---------------- >> 1 file changed, 17 insertions(+), 16 deletions(-) >> >> diff --git a/arch/powerpc/boot/dts/acp342x.dts >> b/arch/powerpc/boot/dts/acp342x.dts >> index b851788..f5cf3a6 100644 >> --- a/arch/powerpc/boot/dts/acp342x.dts >> +++ b/arch/powerpc/boot/dts/acp342x.dts >> @@ -90,64 +90,65 @@ >> clock-frequency = <0>; // Filled in by zImage >> UART0: serial@00404000 { >> device_type = "serial"; >> - compatible = "acp-uart0"; >> + compatible = "lsi,acp-uart0"; >> enabled = <1>; >> reg = <0x00404000 0x1000>; >> clock-reg = <0x00408040 0x20>; >> clock-frequency = <0xbebc200>; >> current-speed = <9600>; >> interrupt-parent = <&MPIC>; >> - interrupts = <22 4>; >> + interrupts = <22>; >> }; >> UART1: serial@00405000 { >> device_type = "serial"; >> - compatible = "acp-uart1"; >> + compatible = "lsi,acp-uart1"; >> enabled = <0>; >> reg = <0x00405000 0x1000>; >> clock-reg = <0x00408060 0x20>; >> clock-frequency = <200000000>; >> current-speed = <9600>; >> interrupt-parent = <&MPIC>; >> - interrupts = <23 4>; >> + interrupts = <23>; >> }; >> USB0: usb@004a4000 { >> device_type = "usb"; >> - compatible = "acp-usb"; >> - enabled = <0>; >> - reg = <0x004a4000 0x00020000>; >> + compatible = "lsi,acp-usb"; >> + enabled = <1>; >> + reg = <0x20 0x004A0000 0x0 0020000>, >> + <0x20 0x0040C000 0x0 0001000>; >> interrupt-parent = <&MPIC>; >> - interrupts = <31 4>; >> + interrupts = <31>; >> }; >> I2C: i2c@00403000 { >> - compatible = "acp-i2c"; >> + compatible = "lsi,acp-i2c"; >> enabled = <0>; >> reg = <0x00403000 0x00001000>; >> interrupt-parent = <&MPIC>; >> - interrupts = <21 4>; >> + interrupts = <21>; >> }; >> SSP: ssp@00402000 { >> - compatible = "acp-ssp"; >> + compatible = "arm,acp-ssp"; >> enabled = <0>; >> reg = <0x00402000 0x00001000>; >> interrupt-parent = <&MPIC>; >> - interrupts = <20 4>; >> + interrupts = <20>; >> }; >> NAND: nand@00440000 { >> device_type = "nand"; >> - compatible = "acp-nand"; >> + compatible = "lsi,acp-nand"; >> enabled = <1>; >> reg = <0x00440000 0x20000 >> 0x0040c000 0x1000>; >> }; >> FEMAC: femac@00480000 { >> device_type = "network"; >> - compatible = "acp-femac"; >> + compatible = "lsi,acp-femac"; >> enabled = <1>; >> reg = <0x00480000 0x1000 >> 0x00481000 0x1000 >> 0x00482000 0x1000>; >> interrupt-parent = <&MPIC>; >> - interrupts = <33 4>; >> + interrupts = <33>; >> mdio-reg = <0x00409000 0x1000>; >> // The following will get filled in by >> // the boot loader. >> @@ -284,7 +285,7 @@ >> }; >> >> rio0: rapidio@f0020000 { >> - compatible = "acp,rapidio-delta"; >> + compatible = "lsi,rapidio-delta"; >> device_type = "rapidio"; >> enabled = <0>; >> #size = <0>; /* 0 = (256, small system) >> > > _______________________________________________ linux-yocto mailing list linux-yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/linux-yocto
