Noted. Will add the details in and resend. Thanks > -----Original Message----- > From: Darren Hart [mailto:dvh...@linux.intel.com] > Sent: 19 March, 2014 1:43 PM > To: Chang, Rebecca Swee Fun; linux-yocto@yoctoproject.org > Subject: Re: [linux-yocto] [PATCH 2/2] meta: add new bsp config layer for > valleyisland > > On 3/19/14, 3:20, "rebecca.swee.fun.ch...@intel.com" > <rebecca.swee.fun.ch...@intel.com> wrote: > > >From: "Chang, Rebecca Swee Fun" <rebecca.swee.fun.ch...@intel.com> > > > >Added configs and scc files for Valley Island BSP. > > Similar comment about the commit message here, but some additional > commentary inline below... > > > > >Signed-off-by: Chang, Rebecca Swee Fun > ><rebecca.swee.fun.ch...@intel.com> > >--- > > .../valleyisland/valleyisland-32-preempt-rt.scc | 16 ++++++ > > .../bsp/valleyisland/valleyisland-32-standard.scc | 15 +++++ > > .../bsp/valleyisland/valleyisland-32.scc | 22 ++++++++ > > .../bsp/valleyisland/valleyisland-preempt-rt.scc | 16 ++++++ > > .../bsp/valleyisland/valleyisland-standard.scc | 15 +++++ > > .../kernel-cache/bsp/valleyisland/valleyisland.cfg | 58 > >++++++++++++++++++++ > > .../kernel-cache/bsp/valleyisland/valleyisland.scc | 22 ++++++++ > > 7 files changed, 164 insertions(+) > > create mode 100644 > >meta/cfg/kernel-cache/bsp/valleyisland/valleyisland-32-preempt-rt.scc > > create mode 100644 > >meta/cfg/kernel-cache/bsp/valleyisland/valleyisland-32-standard.scc > > create mode 100644 > >meta/cfg/kernel-cache/bsp/valleyisland/valleyisland-32.scc > > create mode 100644 > >meta/cfg/kernel-cache/bsp/valleyisland/valleyisland-preempt-rt.scc > > create mode 100644 > >meta/cfg/kernel-cache/bsp/valleyisland/valleyisland-standard.scc > > create mode 100644 > >meta/cfg/kernel-cache/bsp/valleyisland/valleyisland.cfg > > create mode 100644 > >meta/cfg/kernel-cache/bsp/valleyisland/valleyisland.scc > > > >diff --git > >a/meta/cfg/kernel-cache/bsp/valleyisland/valleyisland-32-preempt-rt.scc > >b/meta/cfg/kernel-cache/bsp/valleyisland/valleyisland-32-preempt-rt.scc > >new file mode 100644 > >index 0000000..a733773 > >--- /dev/null > >+++ > >b/meta/cfg/kernel-cache/bsp/valleyisland/valleyisland-32-preempt-rt.scc > >@@ -0,0 +1,16 @@ > >+define KMACHINE valleyisland-32 > >+define KTYPE preempt-rt > >+define KARCH i386 > >+ > >+# no new branch required, re-use the ktypes/preempt-rt/preempt-rt.scc > >branch > >+include ktypes/preempt-rt/preempt-rt.scc > >+ > >+include valleyisland-32.scc > >+ > >+include cfg/efi-ext.scc > >+ > >+# default policy for preempt-rt kernels include > >+cfg/usb-mass-storage.scc include cfg/boot-live.scc include > >+features/latencytop/latencytop.scc > >+include features/profiling/profiling.scc > > These four should really be part of the standard ktype by now... Are the not? > Can you confirm that these are truly still required here? > > > >diff --git > >a/meta/cfg/kernel-cache/bsp/valleyisland/valleyisland-32-standard.scc > >b/meta/cfg/kernel-cache/bsp/valleyisland/valleyisland-32-standard.scc > >new file mode 100644 > >index 0000000..3050bc7 > >--- /dev/null > >+++ b/meta/cfg/kernel-cache/bsp/valleyisland/valleyisland-32-standard.s > >+++ cc > >@@ -0,0 +1,15 @@ > >+define KMACHINE valleyisland-32 > >+define KTYPE standard > >+define KARCH i386 > >+ > >+include ktypes/standard/standard.scc > >+ > >+include valleyisland-32.scc > >+ > >+include cfg/efi-ext.scc > >+ > >+# default policy for standard kernels > >+include cfg/usb-mass-storage.scc > >+include cfg/boot-live.scc > >+include features/latencytop/latencytop.scc > >+include features/profiling/profiling.scc > > Same here > > >diff --git a/meta/cfg/kernel-cache/bsp/valleyisland/valleyisland-32.scc > >b/meta/cfg/kernel-cache/bsp/valleyisland/valleyisland-32.scc > >new file mode 100644 > >index 0000000..3f71467 > >--- /dev/null > >+++ b/meta/cfg/kernel-cache/bsp/valleyisland/valleyisland-32.scc > >@@ -0,0 +1,22 @@ > >+kconf hardware valleyisland.cfg > >+ > >+include cfg/x86.scc > >+include cfg/efi.scc > >+include cfg/dmaengine.scc > >+include cfg/8250.scc > >+ > >+include features/power/intel.scc > >+ > >+include features/i2c/i2c.scc > >+include features/i2c/i2cdev.scc > >+ > >+include features/i915/i915.scc > >+ > >+include features/intel-e1xxxx/intel-e100.scc > >+include features/intel-e1xxxx/intel-e1xxxx.scc > >+ > >+include features/spi/spi.scc > >+include features/spi/spidev.scc > >+ > >+include features/usb/ehci-hcd.scc > >+include features/usb/xhci-hcd.scc > >diff --git > >a/meta/cfg/kernel-cache/bsp/valleyisland/valleyisland-preempt-rt.scc > >b/meta/cfg/kernel-cache/bsp/valleyisland/valleyisland-preempt-rt.scc > >new file mode 100644 > >index 0000000..ed11e0d > >--- /dev/null > >+++ b/meta/cfg/kernel-cache/bsp/valleyisland/valleyisland-preempt-rt.sc > >+++ c > >@@ -0,0 +1,16 @@ > >+define KMACHINE valleyisland > >+define KTYPE preempt-rt > >+define KARCH x86_64 > >+ > >+# no new branch required, re-use the ktypes/preempt-rt/preempt-rt.scc > >branch > >+include ktypes/preempt-rt/preempt-rt.scc > >+ > >+include valleyisland.scc > >+ > >+include cfg/efi-ext.scc > >+ > >+# default policy for preempt-rt kernels include > >+cfg/usb-mass-storage.scc include cfg/boot-live.scc include > >+features/latencytop/latencytop.scc > >+include features/profiling/profiling.scc > >diff --git > >a/meta/cfg/kernel-cache/bsp/valleyisland/valleyisland-standard.scc > >b/meta/cfg/kernel-cache/bsp/valleyisland/valleyisland-standard.scc > >new file mode 100644 > >index 0000000..1d946be > >--- /dev/null > >+++ b/meta/cfg/kernel-cache/bsp/valleyisland/valleyisland-standard.scc > >@@ -0,0 +1,15 @@ > >+define KMACHINE valleyisland > >+define KTYPE standard > >+define KARCH x86_64 > >+ > >+include ktypes/standard/standard.scc > >+ > >+include valleyisland.scc > >+ > >+include cfg/efi-ext.scc > >+ > >+# default policy for standard kernels > >+include cfg/usb-mass-storage.scc > >+include cfg/boot-live.scc > >+include features/latencytop/latencytop.scc > >+include features/profiling/profiling.scc > >diff --git a/meta/cfg/kernel-cache/bsp/valleyisland/valleyisland.cfg > >b/meta/cfg/kernel-cache/bsp/valleyisland/valleyisland.cfg > >new file mode 100644 > >index 0000000..140a006 > >--- /dev/null > >+++ b/meta/cfg/kernel-cache/bsp/valleyisland/valleyisland.cfg > >@@ -0,0 +1,58 @@ > >+CONFIG_MCORE2=y > >+CONFIG_X86_INTEL_LPSS=y > >+CONFIG_PRINTK=y > >+CONFIG_PRINTK_TIME=y > >+ > >+# Basic hardware support for the box - Network, USB, PCI, Sound > >+CONFIG_PM=y CONFIG_ASPM=y > >+ > >+CONFIG_PCI=y > >+CONFIG_PCIEPORTBUS=y > >+ > >+CONFIG_INPUT=y > >+CONFIG_INPUT_EVDEV=y > >+ > >+CONFIG_SOUND=y > >+CONFIG_SND=y > >+CONFIG_SND_HDA_INTEL=y > >+ > >+CONFIG_BACKLIGHT_LCD_SUPPORT=y > >+CONFIG_BACKLIGHT_CLASS_DEVICE=y > >+ > >+# SATA Support > >+CONFIG_ATA=y > >+CONFIG_ATA_GENERIC=y > >+CONFIG_CHR_DEV_SG=y > >+CONFIG_SATA_AHCI=y > >+CONFIG_ATA_PIIX=y > >+ > >+# MMC / SDHCI Support > >+CONFIG_MMC=y > >+CONFIG_MMC_SDHCI=y > >+CONFIG_MMC_SDHCI_PCI=y > >+CONFIG_MMC_SDHCI_ACPI=y > >+ > >+# Graphics Support > >+CONFIG_DRM=y > >+CONFIG_DRM_EMGD=y > > I think some of the above can probably be dropped as it is in standard > already, INPUT has its own fragment as well, but EMGD absolutely should > NOT be present here as it should only be enabled when the DRM EMGD > feature itself is used which includes the merge of the sources. > > Otherwise, this is looking pretty well formed and nearly ready to go. > > Given the DRM_EMGD inclusion here, that tells me you haven't audited the > output of the build to determine if you have reset, mismatched, missing, or > other issues with your final .config. See the logs in the > tmp/work/valleyisland*/linux- > yocto*/*/linux/.meta/cfg/standard/valleyisland > */* > > Those will tell you about any issues with the assembly of your .config, and > if it > is missing anything you have requested. The EMGD option should show up in > there as missing, for example. > > Thanks, > > Darren > > >+ > >+# GPIO Support > >+CONFIG_GENERIC_GPIO=y > >+CONFIG_GPIOLIB=y > >+CONFIG_GPIO_SYSFS=y > >+CONFIG_GPIO_ACPI=y > >+ > >+# PWM Support > >+CONFIG_PWM_SYSFS=y > >+ > >+# SMBus Support > >+CONFIG_I2C_I801=y > >+ > >+# USB Device Support > >+CONFIG_USB_DWC3=y > >+CONFIG_USB_DWC3_GADGET=y > >+CONFIG_USB_GADGET=y > >+CONFIG_USB_LIBCOMPOSITE=m > >+CONFIG_USB_MASS_STORAGE=m > >+CONFIG_NOP_USB_XCEIV=y > >diff --git a/meta/cfg/kernel-cache/bsp/valleyisland/valleyisland.scc > >b/meta/cfg/kernel-cache/bsp/valleyisland/valleyisland.scc > >new file mode 100644 > >index 0000000..0ab5650 > >--- /dev/null > >+++ b/meta/cfg/kernel-cache/bsp/valleyisland/valleyisland.scc > >@@ -0,0 +1,22 @@ > >+kconf hardware valleyisland.cfg > >+ > >+include cfg/x86_64.scc > >+include cfg/efi.scc > >+include cfg/dmaengine.scc > >+include cfg/8250.scc > >+ > >+include features/power/intel.scc > >+ > >+include features/i2c/i2c.scc > >+include features/i2c/i2cdev.scc > >+ > >+include features/i915/i915.scc > >+ > >+include features/intel-e1xxxx/intel-e100.scc > >+include features/intel-e1xxxx/intel-e1xxxx.scc > >+ > >+include features/spi/spi.scc > >+include features/spi/spidev.scc > >+ > >+include features/usb/ehci-hcd.scc > >+include features/usb/xhci-hcd.scc > >-- > >1.7.10.4 > > > >-- > >_______________________________________________ > >linux-yocto mailing list > >linux-yocto@yoctoproject.org > >https://lists.yoctoproject.org/listinfo/linux-yocto > > > > > -- > Darren Hart > Yocto Project - Linux Kernel > Intel Open Source Technology Center > > >
-- _______________________________________________ linux-yocto mailing list linux-yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/linux-yocto
