On Thu, Apr 3, 2014 at 4:25 AM, Stanacar, StefanX
<stefanx.stana...@intel.com> wrote:
>
> Hi Bruce,
>
> On Wed, 2014-04-02 at 11:44 -0400, Bruce Ashfield wrote:
>> On 14-04-02 11:11 AM, Stanacar, StefanX wrote:
>> >
>> >
>> >
>> > On Wed, 2014-04-02 at 00:19 -0700, Darren Hart wrote:
>> >> CONFIG_X86_32 is a non-selectable configuration item, automatically set
>> >> by ARCH and !CONFIG_64BIT. There are no users of the .cfg nor the .scc.
>> >> Delete them.
>> >>
>> >> Signed-off-by: Darren Hart <dvh...@linux.intel.com>
>> >> ---
>> >> meta/cfg/kernel-cache/cfg/x32.cfg | 1 -
>> >> meta/cfg/kernel-cache/cfg/x32.scc | 4 ----
>> >> 2 files changed, 5 deletions(-)
>> >> delete mode 100644 meta/cfg/kernel-cache/cfg/x32.cfg
>> >> delete mode 100644 meta/cfg/kernel-cache/cfg/x32.scc
>> >>
>> >
>> > Does this mean oe-core will need an update on linux-yocto*.bb which has:
>> >
>> > KERNEL_FEATURES_append = " ${@bb.utils.contains("TUNE_FEATURES", "mx32",
>> > " cfg/x32.scc", "" ,d)}"
>>
>> Yes it does. I even grepped/checked for this explicitly and missed it.
>> To top it off, I pushed the change by mistake (long story) this morning.
>>
>> So if we update SRCREVs, this breaks the build for 3.14 based kernels.
>>
>> We could keep an empty .scc file around to keep the interface consistent
>> (and comment in the .scc file why it is empty), or do the updates.
>>
>> preferences ?
>>
>
> I think we need to revert this commit, before updating the SRCREVs. See
> my other reply and Darren's reply. He wanted to remove X86_32 not
> X86_X32. If we remove this config we won't be able (by default) to build
> images for the x86-64-32 tune. (and nightly-x32 on the AB will get red
> and I know someone who doesn't like that :))
Yep, I reverted and pushed it last night. My SRCREV updates will still have
the x32 fragment available.
Bruce
>
> Cheers,
> Stefan
>
>
>> Bruce
>>
>> >
>> > ?
>> >
>> > Cheers,
>> > Stefan
>> >
>> >
>> >> diff --git a/meta/cfg/kernel-cache/cfg/x32.cfg
>> >> b/meta/cfg/kernel-cache/cfg/x32.cfg
>> >> deleted file mode 100644
>> >> index 725e05f..0000000
>> >> --- a/meta/cfg/kernel-cache/cfg/x32.cfg
>> >> +++ /dev/null
>> >> @@ -1 +0,0 @@
>> >> -CONFIG_X86_X32=y
>> >> diff --git a/meta/cfg/kernel-cache/cfg/x32.scc
>> >> b/meta/cfg/kernel-cache/cfg/x32.scc
>> >> deleted file mode 100644
>> >> index e4b954a..0000000
>> >> --- a/meta/cfg/kernel-cache/cfg/x32.scc
>> >> +++ /dev/null
>> >> @@ -1,4 +0,0 @@
>> >> -define KFEATURE_DESCRIPTION "x86 x32 support"
>> >> -define KFEATURE_COMPATIBILITY arch
>> >> -
>> >> -kconf non-hardware x32.cfg
>> >> --
>> >> 1.7.9.5
>> >>
>> >
>>
>
> --
> _______________________________________________
> linux-yocto mailing list
> linux-yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/linux-yocto
--
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"
--
_______________________________________________
linux-yocto mailing list
linux-yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/linux-yocto
