From: Andy Shevchenko <andriy.shevche...@linux.intel.com> Obviously in the current place the 'else' keyword is redundant, though it seems quite correct when we check if nval is in allowed range.
Reattach the condition branch there. Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> Reviewed-by: Mika Westerberg <mika.westerb...@linux.intel.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wyso...@intel.com> (cherry picked from commit 7dc59dc938f034c69dcf9080d45b936882b7ffa3) Signed-off-by: Voon, Weifeng <weifeng.v...@intel.com> --- drivers/acpi/property.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c index 7836e2e..6d99450 100644 --- a/drivers/acpi/property.c +++ b/drivers/acpi/property.c @@ -528,13 +528,14 @@ int acpi_dev_prop_read(struct acpi_device *adev, const char *propname, if (!val) return obj->package.count; - else if (nval <= 0) - return -EINVAL; if (nval > obj->package.count) return -EOVERFLOW; + else if (nval <= 0) + return -EINVAL; items = obj->package.elements; + switch (proptype) { case DEV_PROP_U8: ret = acpi_copy_property_array_u8(items, (u8 *)val, nval); -- 1.9.1 -- _______________________________________________ linux-yocto mailing list linux-yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/linux-yocto