Hi Bruce, Please help to send me a note when you merged the i2c patch, I will discard the local patch files in Ostro OS.
Thanks, Yong -----Original Message----- From: Bruce Ashfield [mailto:bruce.ashfi...@windriver.com] Sent: Thursday, June 2, 2016 8:07 PM To: Li, Yong B <yong.b...@intel.com>; Yong Li <sdliy...@gmail.com> Cc: linux-yocto@yoctoproject.org; s...@linux.intel.com; Wold, Saul <saul.w...@intel.com> Subject: Re: [PATCH] ARM: dts: am335x-boneblack: configure i2c1 and 2 On 2016-06-02 3:41 AM, Li, Yong B wrote: > Hi Bruce, > > Since the patch is used for beaglebone black board, it should be merged into > 4.1 kernel. I have tested the 0001-ARM-dts-Beaglebone-i2c-definitions.patch > in Ostro OS(4.1.6), it works as expected(I2C0/I2C2 are okay). > Aha. Thanks, I had gone back to find your original send and I thought it was against 4.1 .. I must have mis-read! Bruce > Thanks, > Yong > > -----Original Message----- > From: Bruce Ashfield [mailto:bruce.ashfi...@windriver.com] > Sent: Thursday, June 2, 2016 10:51 AM > To: Yong Li <sdliy...@gmail.com> > Cc: Nishanth Menon <n...@ti.com>; Li, Yong B <yong.b...@intel.com>; > linux-yocto@yoctoproject.org; s...@linux.intel.com; Wold, Saul > <saul.w...@intel.com> > Subject: Re: [PATCH] ARM: dts: am335x-boneblack: configure i2c1 and 2 > > On 2016-06-01 9:27 PM, Yong Li wrote: >> Thanks Nishanth! >> >> Hi Bruce, based on the discussion, please merge the >> 5d1a2961adf906f965b00eb8059fd2e0585e0e09 from >> git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git. > > While that is a better upstream reference, the patch didn't cherry pick > cleanly into the 4.4 kernel. > > Have you tried that same cherry pick ? > > Regardless if the patch does come over cleanly, knowing that it worked in a > run time test would be better. > > Bruce > >> >> Regarding I2C1 support, let me try to find/submit another patch. >> >> Thanks, >> Yong >> >> 2016-06-02 3:22 GMT+08:00 Bruce Ashfield <bruce.ashfi...@windriver.com>: >>> On 2016-06-01 02:33 PM, Nishanth Menon wrote: >>>> >>>> On 06/01/2016 01:29 PM, Bruce Ashfield wrote: >>>>> >>>>> On 2016-05-31 10:43 PM, Li, Yong B wrote: >>>>>> >>>>>> Thanks Nishanth for your information. I find the 5d1a2961adf9 >>>>>> commit in linux-omap. It seems to me that it only enables the I2C2 bus. >>>>>> Is it correct? >>>>>> We want to enable both the I2C1 and I2C2 buses for external i2c devices. >>>>>> >>>>> >>>>> As long as it works for what you need (i.e. you've tested it), and >>>>> the patch is from some public repo that I can refernece. I'm ok >>>>> with merging it. >>>>> >>>>>> Hi Bruce, the original source for the patch is >>>>>> https://github.com/nmenon/powertool/blob/master/kernel-patches/00 >>>>>> 0 1-v3.15.0-ARM-dts-am335x-boneblack-configure-i2c1-and-2.patch >>>>> >>>>> >>>>> That's fine with me, can you update the commit log and re-submit >>>>> the patch ? Preferably with a short summary of how you tested the >>>>> change as well. >>>> >>>> >>>> >>>> the patch was created by me on an ancient kernel previously because >>>> there was no dt overlay support. neither i2c1 nor i2c2 are >>>> necessary for BBB to function. as the original author of the patch, >>>> I have to request a NAK. it was specifically done for a power >>>> measurement tool that i had written which runs on BBB (it uses i2c >>>> to read INA226 measurement IC) >>> >>> >>> Aha! Thanks for the history. >>> >>> We definitely want/need the modern support for the buses and addons. >>> So I'll drop this merge. >>> >>> Bruce >>> >>>> >>>> >>> > -- _______________________________________________ linux-yocto mailing list linux-yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/linux-yocto