On 2017-10-04 1:35 AM, Syed Mohamad Fauzi, Syed Johan Arif wrote:
Hi,

Sorry for the late reply, I'll look into it but what's your opinion on the best 
course of action?

The option is currently in a common location. If it is only
applicable to 64bit boards it should either be included directly
by 64 bit BSPs, or put in a fragment that is only included
by those BSPs.

We have bsp/intel-common/intel-corei7-64.scc, which includes
cfg/x86_64.scc.

Putting the x2apic include in either one of those should keep
clear of 32 bit warnings.

Bruce


Kind regards
Johan

-----Original Message-----
From: Bruce Ashfield [mailto:bruce.ashfi...@windriver.com]
Sent: Monday, October 2, 2017 9:25 PM
To: Sullivan, California L <california.l.sulli...@intel.com>; Syed Mohamad Fauzi, 
Syed Johan Arif <syed.johan.arif.syed.mohamad.fa...@intel.com>; 
linux-yocto@yoctoproject.org
Subject: Re: [linux-yocto] [kernel-cache][PATCH] intel-common-drivers: adding 
x2apic

I can always revert the commit, but I'd rather fix it .. Syed ?

Bruce

On 09/29/2017 05:18 PM, Cal Sullivan wrote:
This causes new configcheck warnings for intel-core2-32:

WARNING: linux-intel-4.9.47+gitAUTOINC+e59e19269c_39b77977c6-r0
do_kernel_configcheck: [kernel config]: specified values did not make
it into the kernel's final configuration:

---------- CONFIG_IRQ_REMAP -----------------
Config: CONFIG_IRQ_REMAP
From:
/home/clsulliv/yocto/poky/build/tmp/work-shared/intel-core2-32/kernel-
source/.kernel-meta/configs/standard/intel/features/x2apic/x2apic.cfg

Requested value:  CONFIG_IRQ_REMAP=y
Actual value:

Config 'IRQ_REMAP' has the following conditionals:
    X86_64 && X86_IO_APIC && PCI_MSI && ACPI (value: "n") Dependency
values are:
    X86_64 [n] ACPI [y] X86_IO_APIC [y] PCI_MSI [y]

---------- CONFIG_X86_X2APIC -----------------
Config: CONFIG_X86_X2APIC
From:
/home/clsulliv/yocto/poky/build/tmp/work-shared/intel-core2-32/kernel-
source/.kernel-meta/configs/standard/intel/features/x2apic/x2apic.cfg

Requested value:  CONFIG_X86_X2APIC=y
Actual value:

Config 'X86_X2APIC' has the following conditionals:
    X86_LOCAL_APIC && X86_64 && (IRQ_REMAP || HYPERVISOR_GUEST) (value:
"n") Dependency values are:
    X86_LOCAL_APIC [y] HYPERVISOR_GUEST [n] X86_64 [n] IRQ_REMAP [n]



Seeing that it depends on X86_64, perhaps it should be corei7 specific?

---
Cal

On 09/21/2017 04:28 AM, Syed Mohamad Fauzi, Syed Johan Arif wrote:
Included features/x2apic/x2apic.scc to enable x2apic as a built-in
feature.

Signed-off-by: Syed Mohamad Fauzi, Syed Johan Arif
<syed.johan.arif.syed.mohamad.fa...@intel.com>
---
   bsp/intel-common/intel-common-drivers.scc | 1 +
   1 file changed, 1 insertion(+)

diff --git a/bsp/intel-common/intel-common-drivers.scc
b/bsp/intel-common/intel-common-drivers.scc
index bd56165..6b0de8d 100644
--- a/bsp/intel-common/intel-common-drivers.scc
+++ b/bsp/intel-common/intel-common-drivers.scc
@@ -76,6 +76,7 @@ include cfg/dmaengine.scc
   include features/uio/uio.scc
   include cfg/efi-ext.scc
   include features/input/keyboard-gpio.scc
+include features/x2apic/x2apic.scc
   # default policy for standard kernels
   include cfg/usb-mass-storage.scc



--
_______________________________________________
linux-yocto mailing list
linux-yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/linux-yocto

Reply via email to