Hi Michal,
On 11/4/19 7:51 PM, Michal Simek wrote:
On 29. 10. 19 8:56, quanyang.w...@windriver.com wrote:
From: Quanyang Wang <quanyang.w...@windriver.com>
In include/linux/mailbox/zynqmp-ipi-message.h, it says that
the maximum length of data buffer is fixed to 12 bytes. So
define payload array length to 12 to fix compile warning as
below:
drivers/soc/xilinx/zynqmp_power.c:91:2: warning: ISO C90 forbids variable
length array 'payload' [-Wvla]
91 | u32 payload[msg->len];
| ^~~
Signed-off-by: Quanyang Wang <quanyang.w...@windriver.com>
---
drivers/soc/xilinx/zynqmp_power.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/xilinx/zynqmp_power.c
b/drivers/soc/xilinx/zynqmp_power.c
index 663010658b2a..0036d013aacd 100644
--- a/drivers/soc/xilinx/zynqmp_power.c
+++ b/drivers/soc/xilinx/zynqmp_power.c
@@ -88,7 +88,7 @@ static irqreturn_t zynqmp_pm_isr(int irq, void *data)
static void ipi_receive_callback(struct mbox_client *cl, void *data)
{
struct zynqmp_ipi_message *msg = (struct zynqmp_ipi_message *)data;
- u32 payload[msg->len];
+ u32 payload[12];
int ret;
memcpy(payload, msg->data, sizeof(msg->len));
I don't think it is good idea to put magic numbers to the driver. That's
why create macro in correct header with proper name and use it.
OK, I will send a V2 patch.
Thanks,
Quanyang
M
--
_______________________________________________
linux-yocto mailing list
linux-yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/linux-yocto
