Hello, Adding David Miller to the discussion, as the net-related stuff maintainer
On 8/11/10, Jon Smirl <[email protected]> wrote: > On Tue, Aug 10, 2010 at 4:28 PM, Dmitry Eremin-Solenikov > <[email protected]> wrote: >> On 8/11/10, Dmitry Eremin-Solenikov <[email protected]> wrote: >>> Hello, >>> >>> On 8/10/10, Jon Smirl <[email protected]> wrote: >>>> Other network hardware has a include/linux/if_xxxx.h file describing >>>> it. IEEE 802.15.4 has the same info, it is just spread out over >>>> different files. There are also naming conventions that don't match. >>>> For example IEEE80215_ADDR_LEN vs ARCNET_ALEN, ETH_ALEN, etc... >>> >>> I don't like this change: *_ALEN usually means the length of the _whole_ >>> address as used on the wire. OTOH IEEE802154_ADDR_LEN is the length >>> only of 64bit part of the address. >> >> Reconsidering: you can add _ALEN constant to the ieee802154.h header, >> while >> not removing IEEE802154_ADDR_LEN from af_ieee801254.h. This should allow >> us to clean up some files which include af_ieee802154.h only to get that >> magic >> 64/8=8 address length constant. > > Take a look at the other versions of linux/if_xxxx to see what is > normally in the file. Fine. Judging from the files I saw, they usually contain: * header structure definitions. - N/A in our case, since most of the fields are of variable size * statistics struct definitions - we currently don't have any specific struct * HLEN (= variadic), ALEN (ok, =8), MTU (= 127? 125? 102?) * FC bits (questionable, I'd prefer to keep them in include/net/, since they don't have to be exported to userspace) So, we can add if_ieee802154.h file like this: #ifndef __IF_IEEE802154_H #define __IF_IEEE802154_H #define IEEE802154_ALEN 8 #define IEEE802154_MTU 102 #endif Would you really like that? -- With best wishes Dmitry ------------------------------------------------------------------------------ This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev _______________________________________________ Linux-zigbee-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
