Hi David, I will try to figure out why link-layer address doesn't work on my setup.
On Mon, May 20, 2013 at 12:14:48AM +0200, David Hauweele wrote: > Hello, > > There is a patch which fixes link-local address uncompression: > > http://permalink.gmane.org/gmane.linux.network.zigbee.devel/1717 > > I came across a similar solution but didn't submit it as another patch > already existed. > This patch instead focus on fragmented packet with link-local address > compression, > which is related but a different bug. > > 2013/5/19 Alexander Aring <alex.ar...@gmail.com>: > > Hi David, > > > > can you use a link-layer address on the current net-next kernel? > > > > I am asking because I can't use a link-layer address currently. > > Your patch doesn't help to solve my problem with link-layer addresses. > > > > > > To your patch: > > > > We get the link-layer addresses from skb not from the allocated > > frame->skb. > > > > Here is the code: > > > > _saddr = mac_cb(skb)->sa.hwaddr; > > _daddr = mac_cb(skb)->da.hwaddr; > > > > Here is skb != frame->skb so we don't need to copy it to frame->skb->cb > > because we already the link-layer addresses from skb->cb. > > > > Is there another place in the code where we get the link-layer addresses > > from allocated "frame" structure? > > frame->skb is used to reassemble the 6lowpan packet when new fragments > are received. > This is the 'fragments assembling' switch at the beginning of > lowpan_process_data(). > It will reassemble fragments until the packet is successfully reassembled. > Once it is, skb is replaced: > > dev_kfree_skb(skb); > skb = frame->skb; > kfree(frame); > ah ok. > And the process continues as with other 6lowpan packets. > > In particular: > > _saddr = mac_cb(skb)->sa.hwaddr; > _daddr = mac_cb(skb)->da.hwaddr; > > Several lines later there are: > > err = lowpan_uncompress_addr(skb, &hdr.saddr, lowpan_llprefix, > lowpan_unc_llconf[tmp], skb->data); > err = lowpan_uncompress_addr(skb, &hdr.daddr, lowpan_llprefix, > lowpan_unc_llconf[tmp], skb->data); I think you mean uncompress and compress here. > > These two lines should use _saddr/_daddr instead of skb->data, which I agree with that. Regards Alex ------------------------------------------------------------------------------ AlienVault Unified Security Management (USM) platform delivers complete security visibility with the essential security capabilities. Easily and efficiently configure, manage, and operate all of your security controls from a single console and one unified framework. Download a free trial. http://p.sf.net/sfu/alienvault_d2d _______________________________________________ Linux-zigbee-devel mailing list Linux-zigbee-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
