Hi,

On Sun, Sep 29, 2013 at 01:57:18AM -0300, Werner Almesberger wrote:
> Alexander Aring wrote:
> > This patch removes some magic number.
> > Instead of magic numbers we use some defines.
> 
> This may be misunderstood. When I read it, my first question was in
> which other patch you defined MAC802154_FRAME_HARD_HEADER_LEN. But
> of course, it already exists. So I'd say something like
> 
>   This patch replaces a redundant open-coded calculation
>   with the already defined MAC802154_FRAME_HARD_HEADER_LEN.
> 

Ok.

> > Acked-by: Werner Almesberger <wer...@almesberger.net>
> 
> By the way, you should use the Acked-by only on patches I've seen.
> While we discussed many things, I didn't comment on all of them.
> Well, I probably will eventually,  so it's hypothetical in this
> case.
> 
Okay, that confused me a little bit too while I add your Acked-by on
these patches. In this time I thought "Should I ask him to add his
Acked-by really"....

I simple misunderstood you in IRC, there you said I can put a Acked-by
because you had helped a little bit on these patches.

BIG sorry about that and shame on me!

- Alex

------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk
_______________________________________________
Linux-zigbee-devel mailing list
Linux-zigbee-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel

Reply via email to