Hi Alex,
On 07/28/2014 01:56 PM, Alexander Aring wrote:
> On Fri, Jul 25, 2014 at 10:12:38AM +0530, varkabhad...@gmail.com wrote:
>> From: Varka Bhadram <var...@cdac.in>
>>
>> It fix the indentation for the switch case as per the kernel
>> coding styles.
>>
>> Signed-off-by: Varka Bhadram <var...@cdac.in>
>> ---
>> net/ieee802154/header_ops.c | 12 ++++++++----
>> 1 file changed, 8 insertions(+), 4 deletions(-)
>>
>> diff --git a/net/ieee802154/header_ops.c b/net/ieee802154/header_ops.c
>> index c09294e..5d6e4d6 100644
>> --- a/net/ieee802154/header_ops.c
>> +++ b/net/ieee802154/header_ops.c
>> @@ -157,10 +157,14 @@ static int ieee802154_hdr_addr_len(int mode, bool
>> omit_pan)
>> int pan_len = omit_pan ? 0 : 2;
>>
>> switch (mode) {
>> - case IEEE802154_ADDR_NONE: return 0;
>> - case IEEE802154_ADDR_SHORT: return 2 + pan_len;
>> - case IEEE802154_ADDR_LONG: return IEEE802154_ADDR_LEN + pan_len;
>> - default: return -EINVAL;
>> + case IEEE802154_ADDR_NONE:
>> + return 0;
>> + case IEEE802154_ADDR_SHORT:
>> + return 2 + pan_len;
>> + case IEEE802154_ADDR_LONG:
>> + return IEEE802154_ADDR_LEN + pan_len;
>> + default:
>> + return -EINVAL;
>> }
>> }
> I don't apply this one, because I don't see that this isn't invalid
> according kernel coding styles.
>
> See Documentation/CodingStyle, there is a part about switch cases and an
> example with your "identation". But the surrounding text describes that
> we should have the indentation of case in the same like switch.
>
> There is not sentence about we can't do something like:
>
> switch (foo) {
> case BAR: return foobar;
> default: return barfoo;
> }
>
> Also checkpatch doesn't say any warning about that. If you get patches
> in to change "Documentation/CodingStyle" to add a part about after "case
> FOOBAR" shuld always be a newline with indentation in the next level,
> then I will apply it.
>
> But for now I don't see any issues according kernel codestyle.
>
> - Alex
Please see :http://lxr.free-electrons.com/source/Documentation/CodingStyle#L38
--
Regards,
Varka Bhadram.
------------------------------------------------------------------------------
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls.
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
_______________________________________________
Linux-zigbee-devel mailing list
Linux-zigbee-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
