On 02/02/2007 11:58 AM, Uwe Hermann wrote: > On Fri, Feb 02, 2007 at 05:50:04PM +0100, Stefan Reinauer wrote: >> Could you please rediff with -w ? Something terribly broke the indenting. > > I guess this was intended. It looks like Roman fixed the coding style(?) > E.g. replaced spaces with tabs in a number of places... > > Such patches should be submitted separately from "real" code changes, > though, to make it easier to review the patches.
Rediffing with -w will not help. Fixing coding style first will not help either. This is not as simple as a patch. It is a major re-writing. The current code in the repository is half-finished and works only by an accident. Reviewers should apply the patch and try to understand what is going on there. Regards, Roman -- linuxbios mailing list linuxbios@linuxbios.org http://www.openbios.org/mailman/listinfo/linuxbios
