Peter Stuge wrote:
>On Wed, Jun 27, 2007 at 10:38:27PM +0200, [EMAIL PROTECTED] wrote:
>
>
>>+++ LinuxBIOSv3/mainboard/adl/msm800sev/initram.c 2007-06-27 20:38:27 UTC
>>(rev 381)
>>
>>
>
>[..]
>
>
>
>>+int main(void)
>>+{
>>+ void done_cache_as_ram_main(void);
>>+ void w83627hf_enable_serial(u8 dev, u8 serial, u16 iobase);
>>+ post_code(POST_START_OF_MAIN);
>>+
>>+ system_preinit();
>>+ geodelx_msr_init();
>>+
>>+ cs5536_early_setup();
>>+
>>+ /* NOTE: must do this AFTER the early_setup!
>>+ * it is counting on some early MSR setup
>>+ * for cs5536
>>+ */
>>+ cs5536_disable_internal_uart();
>>
>>
>
>Shouldn't it go into _early_setup() then?
>
>
>
>
Yes, I think that would be better.
>>+ w83627hf_enable_serial(0x2e, 0x30, 0x3f8);
>>
>>
>
>"Magic" values - shouldn't at least 0x3f8 be a CONFIG_ value?
>
>
>
>
Is there a new dts for the sio?
>>+ /* Switch from Cache as RAM to real RAM */
>>+ printk(BIOS_SPEW, "Before wbinvd\n");
>>+ __asm__("wbinvd\n");
>>+ printk(BIOS_SPEW, "After wbinvd\n");
>>
>>
>
>Isn't there already a function for disabling CAR?
>
>
>
There is a complicated CAR disable function for K8 but this single
instruction is enough for LX. I guess you could call the disable
function and put this one instruction in there.
Marc
>
>
--
linuxbios mailing list
[email protected]
http://www.linuxbios.org/mailman/listinfo/linuxbios
