On Tue, Sep 18, 2007 at 04:16:24PM -0400, Corey Osgood wrote: > Yeah, just blame it all on me ;) I'd like to see this sneak in as well, > wouldn't be the first time a port that wasn't quite finished was committed.
Yeah, true. Let's commit it when the issues from the review(s) are resolved. > >>> Index: src/mainboard/rca/rm4100/Config.lb > >>> > >> RCA RM4100 is the name of the box as a whole, correct? Can you look at > >> the mainboard and search for a vendor and mainboard name/ID? > >> If there is one (printed on the PCB), we should use that as the > >> target name in LinuxBIOS (as we did with other embedded stuff). > >> > >> > > Well, it was originally made by Thomson Electronics Model: IP1000 but > > RCA now manufactures the device and board as Model: RM4100 Just to clarify -- is this the "product" name (the whole box) or the name of the mainboard itself, or both? > Can that be moved into i82801xx_ac97.c (or i82801xx_audio.c, can't > remember what I called it)? Or must it be done before ram init? I have > no audio on my boards, so I had no way to test anything to do with ac97. > Or could it even be dropped into the i82801xx folder in a file like > i82801xx_early_ac97.c and be included from there? > > >> Not _too_ different to i815, it seems. Any chance this code could be > >> merged into the i815 code, with some i830 specifics special-cased? > >> If that's possible I'd really prefer it over creating another > >> near-duplicate code base. > >> > >> > > Actually the i830 is more like the i845 chipset, but it is adaptable, > > I'm sure. > > i815? Do you mean i810? And the i810 isn't close enough even to the i815 Yep, I meant i810, sorry. I'll have a look at the datasheets. The chipsets don't have to be completely similar, some degree of variation is ok, we can use #ifdefs, different header files, runtime checks etc. to work around differences. If there are simply too _many_ of them the code becomes unreadable, in that case merging them does indeed not make sense. Uwe. -- http://www.hermann-uwe.de | http://www.holsham-traders.de http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
signature.asc
Description: Digital signature
-- linuxbios mailing list [email protected] http://www.linuxbios.org/mailman/listinfo/linuxbios
