Since my hard drive literally screamed at me today, I figured it is time
to send my current raw v2 diff to the list. Some parts of it are already
acked, some are just reminders something is wrong.
Carl-Daniel
Index: src/southbridge/nvidia/mcp55/mcp55_nic.c
===================================================================
--- src/southbridge/nvidia/mcp55/mcp55_nic.c (Revision 2802)
+++ src/southbridge/nvidia/mcp55/mcp55_nic.c (Arbeitskopie)
@@ -83,11 +83,13 @@
if (val < 0 || val == 0xffff) continue;
id |= ((val & 0xffff)<<16);
printk_debug("MCP55 MAC PHY ID 0x%08x PHY ADDR %d\n", id, i);
+#warn The comment below changes the for loop to a non-loop
// if((id == 0xe0180000) || (id==0x0032cc00))
break;
}
if(i>32) {
+#error Because of the comment above, this code path will never be entered
printk_debug("MCP55 MAC PHY not found\n");
}
Index: src/devices/device_util.c
===================================================================
--- src/devices/device_util.c (Revision 2802)
+++ src/devices/device_util.c (Arbeitskopie)
@@ -467,10 +467,11 @@
#endif
}
printk_debug(
- "%s %02x <- [0x%010Lx - 0x%010Lx] %s%s%s\n",
+ "%s %02x <- [0x%010Lx - 0x%010Lx] size 0x%08Lx gran
0x%02x %s%s%s\n",
dev_path(dev),
resource->index,
base, end,
+ resource->size, resource->gran,
buf,
resource_type(resource),
comment);
Index: src/superio/ite/it8712f/superio.c
===================================================================
--- src/superio/ite/it8712f/superio.c (Revision 2802)
+++ src/superio/ite/it8712f/superio.c (Arbeitskopie)
@@ -132,6 +132,12 @@
static void enable_dev(struct device *dev)
{
+ /* FIXME: is dev the right type?
+ How can we signal error if the superio isn't the expected one? */
+ #error Test the values for real
+ 0x87 == pnp_read_config(dev, 0x20);
+ 0x12 == pnp_read_config(dev, 0x21);
+
pnp_enable_devices(dev, &pnp_ops,
sizeof(pnp_dev_info)/sizeof(pnp_dev_info[0]), pnp_dev_info);
}
Index: src/lib/lzma.c
===================================================================
--- src/lib/lzma.c (Revision 2802)
+++ src/lib/lzma.c (Arbeitskopie)
@@ -1,9 +1,13 @@
/*
LinuxBIOS interface to memory-saving variant of LZMA decoder
+
(C)opyright 2006 Carl-Daniel Hailfinger
-Released under the GNU GPL
+Released under the GNU GPL v2 or later
+Parts of this file are based on C/7zip/Compress/LZMA_C/LzmaTest.c from the LZMA
+SDK 4.42, which is written and distributed to public domain by Igor Pavlov.
+
*/
#include "lzmadecode.c"
Index: src/arch/i386/include/stdint.h
===================================================================
--- src/arch/i386/include/stdint.h (Revision 2802)
+++ src/arch/i386/include/stdint.h (Arbeitskopie)
@@ -37,7 +37,7 @@
typedef signed long long int_least64_t;
#endif
-/* Fast Types */
+/* Fast types */
typedef unsigned char uint_fast8_t;
typedef signed char int_fast8_t;
@@ -52,6 +52,29 @@
typedef signed long long int_fast64_t;
#endif
+/* Kernel types */
+typedef unsigned char u8;
+typedef signed char s8;
+typedef unsigned char __u8;
+typedef signed char __s8;
+
+typedef unsigned short u16;
+typedef signed short s16;
+typedef unsigned short __u16;
+typedef signed short __s16;
+
+typedef unsigned int u32;
+typedef signed int s32;
+typedef unsigned int __u32;
+typedef signed int __s32;
+
+#if __HAVE_LONG_LONG__
+typedef unsigned long long u64;
+typedef signed long long s64;
+typedef unsigned long long __u64;
+typedef signed long long __s64;
+#endif
+
/* Types for `void *' pointers. */
typedef int intptr_t;
typedef unsigned int uintptr_t;
--
linuxbios mailing list
[email protected]
http://www.linuxbios.org/mailman/listinfo/linuxbios
