* Uwe Hermann <[EMAIL PROTECTED]> [071010 20:47]:
> OK, second try, this time adding instead of removing full stops.
>
>
> Uwe.
> --
> http://www.hermann-uwe.de | http://www.holsham-traders.de
> http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
> Some cosmetic cleanups in the flashrom code and output.
>
> Signed-off-by: Uwe Hermann <[EMAIL PROTECTED]>
> if (ret)
> - printf("Failed!\n");
> + printf("failed!\n");
Since we use a capital "OK" some times, should we also use a capital
FAILED ? This is usually a pretty nasty situation.
> - fprintf(stdout, "Found LinuxBIOS table at: %08lx\n", addr);
> + fprintf(stdout, "Found LinuxBIOS table at 0x%08lx.\n", addr);
Maybe even %p?
> - printf_debug("lb_table found at address %p\n", lb_table);
> + printf_debug("LinuxBIOS table found at 0x%p.\n", lb_table);
%p already prints 0x on my system... so this would be 0x0x00000500 or so
> if (board) {
> - printf("Found board \"%s\": Enabling flash write... ",
> + printf("Found board \"%s\", enabling flash write... ",
> board->name);
>
> ret = board->enable(board->name);
> if (ret)
> - printf("Failed!\n");
> + printf("failed!\n");
I'd rather leave words after periods capital. Maybe we should even
CAPITALIZE it completely since it's a failure condition?
Stefan
--
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: [EMAIL PROTECTED] • http://www.coresystems.de/
--
linuxbios mailing list
linuxbios@linuxbios.org
http://www.linuxbios.org/mailman/listinfo/linuxbios
