On Thu, Oct 11, 2007 at 09:39:54AM -0700, ron minnich wrote: > attached. I am working to integrate the SIS NB support in, as the > discussion seems to have > gone silent.
I'm not sure what the course of action is here -- shall we try to modify the code ourselves or wait for SiS developers? I don't want to duplicate any efforts and we probably cannot easily test our changes right now... > These files are now used in more than one place, so we copy them here, prior > to removing them elsewhere. Nope, please make the moving of the files one atomic commit, i.e. use 'svn mv foo.h bar.h' as appropriate. Further _changes_ to the files (apart from moving them) should be an extra patch/commit. > I don't see a need for a long debate about location, given that we plan to > transition to v3 in the > next 18 months. As Stefan said, you didn't specify a location anyway. Maybe simply src/include/? We have spd.h there, too. > There is no copyright notice, and I can't figure out where they came from; I > am not sure we should > put one in. Yes, we should, as in every other file. But if they don't have a GPL header right now, we should first move the files with 'svn mv' and add headers later. > Index: spd_ddr2.h Do we really want this in an extra file, or just merge it into the already existing src/include/spd.h? > Index: amdk8.h > Index: amdk8_f.h Why move these files? And from where to where? They're likely K8 specific and located in src/northbridge/amd/amdk8/ (which sounds correct), so why move them? Uwe. -- http://www.hermann-uwe.de | http://www.holsham-traders.de http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
signature.asc
Description: Digital signature
-- linuxbios mailing list linuxbios@linuxbios.org http://www.linuxbios.org/mailman/listinfo/linuxbios
