On Fri, Oct 19, 2007 at 01:51:28AM +0200, Uwe Hermann wrote: > Comments welcome, Uwe.
On Fri, Oct 19, 2007 at 09:33:21PM +0200, Uwe Hermann wrote: > > That sounds not right. Is there other way to refactor? > > I can't think of a better way to do it, but I'm open to > suggestions. I think this is too much work for v2. > The #elif's are a cheap price when we can get rid of all the > duplicated files we had before. For v2, I think I'm with Ron. Duplicated code and files isn't that bad. Yes, it's dirty, but rather than cleaning it up piece by piece I'd like to work on v3. > There are just 2-3 places where you have to add your board in the > #elif. > > On the long run (in v3 maybe) How long is "long" ? > we could make the framework a bit more generic, to allow to plug in > different Super I/Os etc., without having to #ifdef all of them... Isn't this the case already? Bottom line: I would much rather see this effort go into v3 and a bonus is that many of the boards supported by v2 would be working also with v3. And: #ifdef/#elif is really ugly. At least do #include instead? //Peter -- linuxbios mailing list linuxbios@linuxbios.org http://www.linuxbios.org/mailman/listinfo/linuxbios
