Uwe Hermann wrote: > On Sun, Oct 28, 2007 at 08:04:26PM -0400, Corey Osgood wrote: > >> Add support for the Fintek F71805f to LinuxBIOSv3. It hasn't been tested yet >> because something's failing to build elsewhere, but the stage1 does build, >> and >> for the moment that's what matters. It's based on working v2 code so it >> should >> work fine. >> >> Signed-off-by: Corey Osgood <[EMAIL PROTECTED]> >> > > Looks nice, but I'd prefer to make it a generic driver for most Fintek > chips while we're at it. > > Please look at 'smscsuperio' in v2 (which supports 10-15 Super I/Os), > ideally this would be a similar generic Fintek driver code, which supports > most of the Fintek chips. > > Please model the code in a similar way as in 'smscsuperio' and repost. > > No need to add support for _all_ or multiple Fintek chips, but > please create the framework code in a way that other Fintek chips > can be added easily later. Ideally such an addition would only require > you to add the device IDs in a table, and the LDNs to another table. > > Feel free to check superiotool for hints on detection of chips, > and how to keep them apart / probe for them etc.
Then forget the patch. I'll work on that once the rest of the hardware is working. Getting ram init working is about a million times more important to me than getting the rest of the fintek lineup working. Not to mention that I have no other fintek chips, so no way to test. -Corey -- linuxbios mailing list linuxbios@linuxbios.org http://www.linuxbios.org/mailman/listinfo/linuxbios
