On 07/12/07 22:51 -0500, Corey Osgood wrote: > Jordan Crouse wrote: > > > > HOST_CC=gcc > > -HOST_CFLAGS= > > +HOST_CFLAGS=$(STACKPROTECT)
> Okay, there's reason that I've left just this part of the patch. With > the patch this way, mkelfimage builds (awesome, thanks!), but lzma fails: > > make[1]: Leaving directory > `/home/amp/linuxbios/buildrom/buildrom-devel/work/unifdef/unifdef-1.0' > Building lzma... > export: 4: -fno-stack-protector: bad variable name > make: *** > [/home/amp/linuxbios/buildrom/buildrom-devel/work/lzma/lzma-443/C/7zip/Compress/LZMA_Alone/lzma] > Error 2 > With quotes around $(STACKPROTECT), lzma finishes, but mkelfimage fails: The quotes should go around $(HOST_CFLAGS) in the lzma.mk, no in Build.settings. Patch attached (apply against the mkelfimage patch). Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc.
[BUILDROM] Fix -fno-stack-protector for LZMA The patch to fix the mkelfimage build broke LZMA, but this is an easy (and correct) fix that belongs everywhere, not just here. Signed-off-by: Jordan Crouse <[EMAIL PROTECTED]> Index: buildrom-devel/packages/lzma/lzma.mk =================================================================== --- buildrom-devel.orig/packages/lzma/lzma.mk 2007-12-10 11:30:46.000000000 -0700 +++ buildrom-devel/packages/lzma/lzma.mk 2007-12-10 11:36:53.000000000 -0700 @@ -24,8 +24,8 @@ $(LZMA_SRC_DIR)/C/7zip/Compress/LZMA_Alone/lzma: $(LZMA_STAMP_DIR)/.unpacked @ echo "Building lzma..." - @ ( export CC=$(HOST_CC); export CFLAGS=$(HOST_CFLAGS); \ - export LDFLAGS=$(HOST_LDFLAGS); unset LIBS; \ + @ ( export CC=$(HOST_CC); export CFLAGS="$(HOST_CFLAGS)"; \ + export LDFLAGS="$(HOST_LDFLAGS)"; unset LIBS; \ cd $(LZMA_SRC_DIR)/C/7zip/Compress/LZMA_Alone; \ $(MAKE) -C $(LZMA_SRC_DIR)/C/7zip/Compress/LZMA_Alone -f makefile.gcc > $(LZMA_BUILD_LOG) 2>&1 )
-- linuxbios mailing list linuxbios@linuxbios.org http://www.linuxbios.org/mailman/listinfo/linuxbios