Myles Watson wrote: >> Please focus most >> attention on the few places where changes were made to preexisting >> files. > >> Index: LinuxBIOSv2/src/config/Options.lb >> =================================================================== >> --- LinuxBIOSv2.orig/src/config/Options.lb 2007-12-12 >> 11:03:38.000000000 -0700 >> +++ LinuxBIOSv2/src/config/Options.lb 2007-12-12 14:16:22.000000000 >> ->0700 >> @@ -291,6 +291,11 @@ >> export always >> comment "Use data cache as temporary RAM if possible" >> end >> +define CAR_FAM10 >> + default 0 >> + export always >> + comment "AMD family 10 CAR need set more" >> +end > > This could be a little more clear. Did you mean "needs more setup" or > something else? > Fixed.
>> Index: LinuxBIOSv2/src/cpu/amd/car/cache_as_ram.inc >> Index: LinuxBIOSv2/src/cpu/amd/microcode/microcode.c > > It looks like most of the changes are white space in these files. It would > be a lot easier to understand the changes if you submitted the patch as > 1. a white space and license patch > 2. a CAR_FAM10 patch > Yes, I struggle with this. It is difficult to not clean the code as I develop. I didn't realize it was that much change. I will separate the whitespace changes out. > I also didn't understand why the type change from uint32_t to u32 was > important. > > Myles Just trying to follow the LB guidelines. Maybe I should have left it alone. Marc -- Marc Jones Senior Firmware Engineer (970) 226-9684 Office mailto:[EMAIL PROTECTED] http://www.amd.com/embeddedprocessors -- linuxbios mailing list linuxbios@linuxbios.org http://www.linuxbios.org/mailman/listinfo/linuxbios
