So what is the general consensus ==1 or >0? Also, I think I know how to commit back to the tree, but do I need a user account for this?
/********************* Marc Karasek MTS Sun Microsystems mailto:[EMAIL PROTECTED] ph:770.360.6415 *********************/ Myles Watson wrote: > On Jan 7, 2008 8:15 AM, Marc Karasek <[EMAIL PROTECTED]> wrote: > >> After looking at the script Myles sent, I immediately saw the problem. >> I forgot that if [ $build_id ] will always be true because it checks to >> see if it is defined not the value of build_id. My bad, sorry. >> >> I have made the changes and added an == 1 to the if statement. Attached >> is the new and I hope final patch file for this. >> >> > It works for me (it doesn't add the load option.) > > Sorry to be picky, but it seems like this breaks if they mention > build-id more than once in the help in the future. I think >0 would > be better than ==1. > > With that fixed, or if no one thinks that will ever happen: > Acked-by: Myles Watson <[EMAIL PROTECTED]> > >> /********************* >> Marc Karasek >> MTS >> Sun Microsystems >> mailto:[EMAIL PROTECTED] >> ph:770.360.6415 >> *********************/ >> >> >> >> Ed Swierk wrote: >> >> >>> On 1/4/08, Marc Karasek <[EMAIL PROTECTED]> wrote: >>> >>> >>>> I made a test script and ran it and it sets build_id = 1 properly. I >>>> have also included this script. >>>> >>>> >>> The problem is that on Planet Bourne, zero means true and nonzero means >>> false. >>> >>> --Ed >>> >>> -- linuxbios mailing list linuxbios@linuxbios.org http://www.linuxbios.org/mailman/listinfo/linuxbios
