Ollie Lho <[EMAIL PROTECTED]> writes:

> "Eric W. Biederman" wrote:
> > 
> > Possibly.  My knowledge of python is really poor.  Mostly I'm interpolating
> > from what I know of other languages.  Could you print out value and key.
> > i.e.
> > 
> > print "option: " + key " = " + value
> > 
> > And then we can see which construct is blowing up the configure.
> > 
> 
> The error occurs at _RAM_BASE 16384
> 
> option: ROM_IMAGE_SIZE
>  = 65536
> option: SERIAL_CONSOLE
>  = 
> option: SIS630
>  = 
> option: SMA_SIZE
>  = 0xA0
> option: STACK_SIZE
>  = 0x10000
> option: UPDATE_MICROCODE
>  = 
> option: USE_NEW_SUPERIO_INTERFACE
>  = 
> option: _RAMBASE
> Traceback (innermost last):
>   File "NLBConfig.py", line 703, in ?
>     writeldscript(outputdir)
>   File "NLBConfig.py", line 519, in writeldscript
>     print " = " + value
> TypeError: illegal argument type for built-in operation
> ollie config 312:
> 
> 
> And by ignoring all these errors I should get something like:
> 
> 
> SIS630ROM_IMAGE_SIZE 65536
> SERIAL_CONSOLE  
> SMA_SIZE 0xA0
> STACK_SIZE 0x10000
> UPDATE_MICROCODE 
> USE_NEW_SUPERIO_INTERFACE 
> _RAMBASE 16384
> _ROMBASE 524288
> 
> 
> Why SIS630ROM_IMAGE_SIZE 65536 works and _RAMBASE 16384 failed ??

It looks like _RAMBASE is numeric because of the docipl case.

The following patch fixes it for me. 
Is this good enough or is there another case through that script
that will create numeric values?

> --- checkin/freebios/util/config/NLBConfig.py   Wed Aug 15 14:47:07 2001
+++ freebios/util/config/NLBConfig.py   Wed Aug 15 20:58:50 2001
@@ -341,8 +341,8 @@
        # Now we need a mainboard-specific include path
        userrules.append("\tcc $(CFLAGS) -I%s -c $<" % mainboard_dir)
        # now set new values for the ldscript.ld.  Should be a script? 
-       set_option("_RAMBASE", 0x4000)
-       set_option("_ROMBASE", 0x80000)
+       set_option("_RAMBASE", "0x4000")
+       set_option("_ROMBASE", "0x80000")
 
 def linux(dir, linux_name):
        linuxrule = 'LINUX=' + linux_name

Eric

Reply via email to