Konstantin Zhidkov <[EMAIL PROTECTED]> writes:
> --- Ronald G Minnich <[EMAIL PROTECTED]> wrote:
> >
>
> > I'm going through the code and hope to produce a table of #if
> > and #ifdef
> > used in linuxbios and what they mean soon. Also (this is my
> > fault) we
> > really do need to rename config variables for linuxbios to
> > CONFIG_LINUXBIOS_ to avoid confusion between linuxbios config
> > variables
> > and other variable (e.g. i586). This I will do slowly, along
> > with
> > correcting cases where people used
> > #ifdef x
> > (old style) instead of
> > #if (x == 1)
> > (new style)
> >
>
> There also are some functions that can be conditionally(!)
> defined as do{}while(0). This makes code beautiful but
> misleading. Could there be a naming covention for such
> functions? For exapmle, to start names with i_lie_again_:)
Maybe. I suspect better access to the configuration variables
would be good. Before we had that the code was totally unreadable.
ifdefs cluttered up hardwaremain horribly.
Now looking at the code you can see what would maximally happen. You
just can't trivially tell if it has been configured not to. From
a coding perspecitive you can just assmume everything will happen.
Eric
